Messages in this thread | | | Subject | Re: [PATCH 6/7] debugfs: Fix misuse of seq_printf return value | From | Joe Perches <> | Date | Tue, 28 Oct 2014 08:25:51 -0700 |
| |
On Tue, 2014-10-28 at 10:58 -0400, Steven Rostedt wrote: > On Mon, 29 Sep 2014 16:08:26 -0700 > Joe Perches <joe@perches.com> wrote: > > Adding repeated -1 to the return is not correct. > > Use seq_is_full to test for unnecessary seq_printf uses > > and always return 0. [] > Actually, debugfs_print_regs32() should return void as well. > I'll update that.
Great though this should possibly be another patch.
I didn't want to update the documentation.
Maybe remove the prototype and make it static too.
| |