Messages in this thread | | | Date | Tue, 28 Oct 2014 15:22:01 +0100 | Subject | Re: [PATCH v3 1/2] mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc | From | Frans Klaver <> |
| |
On Tue, Oct 28, 2014 at 11:53 AM, Zhou Wang <wangzhou.bry@gmail.com> wrote: > + > +static int hisi_nfc_probe(struct platform_device *pdev) > +{ > + int ret = 0, irq, buswidth, flag, max_chips = HINFC504_MAX_CHIP; > + struct device *dev = &pdev->dev; > + struct hinfc_host *host; > + struct nand_chip *chip; > + struct mtd_info *mtd; > + struct resource *res; > + struct device_node *np = dev->of_node; > + struct mtd_part_parser_data ppdata; > + > + host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); > + if (!host) > + return -ENOMEM; > + host->dev = dev; > + > + platform_set_drvdata(pdev, host); > + chip = &host->chip; > + mtd = &host->mtd; > + > + irq = platform_get_irq(pdev, 0); > + if (irq < 0) { > + dev_err(dev, "no IRQ resource defined\n"); > + ret = -ENXIO; > + goto err_res; > + } > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + host->iobase = devm_ioremap_resource(dev, res); > + if (IS_ERR(host->iobase)) { > + ret = PTR_ERR(host->iobase); > + dev_err(dev, "devm_ioremap_resource[0] fail\n"); > + goto err_res; > + } > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > + chip->IO_ADDR_R = chip->IO_ADDR_W = devm_ioremap_resource(dev, res); > + if (IS_ERR(chip->IO_ADDR_R)) { > + ret = PTR_ERR(chip->IO_ADDR_R); > + dev_err(dev, "devm_ioremap_resource[1] fail\n"); > + goto err_res; > + } > + > + mtd->priv = chip; > + mtd->owner = THIS_MODULE; > + mtd->name = "hisi_nand";
+ mtd->dev.parent = &pdev->dev;
This is a bug that lives in a bunch of other nand drivers as well. add_mtd_device (called by mtd_device_parse_register()) expects dev.parent to be set for properly adding a device reference to the sysfs node.
Frans
| |