Messages in this thread | | | Date | Tue, 28 Oct 2014 13:57:16 +0800 | From | Ren Qiaowei <> | Subject | Re: [PATCH v9 10/12] x86, mpx: add prctl commands PR_MPX_ENABLE_MANAGEMENT, PR_MPX_DISABLE_MANAGEMENT |
| |
On 10/28/2014 04:38 AM, Thomas Gleixner wrote: > On Mon, 27 Oct 2014, Ren, Qiaowei wrote: >> On 2014-10-24, Thomas Gleixner wrote: >>> On Sun, 12 Oct 2014, Qiaowei Ren wrote: >>>> +int mpx_enable_management(struct task_struct *tsk) { >>>> + struct mm_struct *mm = tsk->mm; >>>> + void __user *bd_base = MPX_INVALID_BOUNDS_DIR; >>> >>> What's the point of initializing bd_base here. I had to look twice to >>> figure out that it gets overwritten by task_get_bounds_dir() >>> >> >> I just want to put task_get_bounds_dir() outside mm->mmap_sem holding. > > What you want is not interesting at all. What's interesting is what > you do and what you send for review. >
I see. Thanks.
- Qiaowei
| |