Messages in this thread | | | Date | Wed, 29 Oct 2014 12:03:33 +0900 | From | Michel Dänzer <> | Subject | Re: [PATCH 02/11 V2] radeon: evergreen: Fix probable mask then right shift defect |
| |
On 28.10.2014 23:06, Alex Deucher wrote: > On Mon, Oct 27, 2014 at 10:14 AM, Joe Perches <joe@perches.com> wrote: >> Precedence of & and >> is not the same and is not left to right. >> shift has higher precedence and should be done after the mask. >> >> Add parentheses around the mask. >> >> Use the already #defined values instead of hardcoding. >> >> Signed-off-by: Joe Perches <joe@perches.com> >> --- >>> I think this should be NUM_SHADER_ENGINES_SHIFT? >> >> (Joe can't type) >> >> exactly right, thanks Michel > > Applied with a compile fix.
Joe, in the future please make sure your patches compile before submitting them.
-- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |