lkml.org 
[lkml]   [2014]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] kobject: Add kobject_initialized() function
On Tue, Oct 28, 2014 at 04:26:47PM +0100, Tomeu Vizoso wrote:
> To be used by users of kobject to tell when one hasn't been initialized yet.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> include/linux/kobject.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/kobject.h b/include/linux/kobject.h
> index 2d61b90..6bb5a92 100644
> --- a/include/linux/kobject.h
> +++ b/include/linux/kobject.h
> @@ -88,6 +88,11 @@ static inline const char *kobject_name(const struct kobject *kobj)
> return kobj->name;
> }
>
> +static inline bool kobject_initialized(const struct kobject *kobj)
> +{
> + return kobj->state_initialized;
> +}

Ick, no. Why would you ever need this? You "own" the kobject, and you
better know if you initialized it or not. If not, you should fix your
use of a kobject.

And why are you even using a kobject at all?

greg k-h


\
 
 \ /
  Last update: 2014-10-29 04:01    [W:0.052 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site