Messages in this thread | | | Date | Mon, 27 Oct 2014 20:07:50 +0300 | From | Andrey Ryabinin <> | Subject | Re: [PATCH v5 07/12] mm: slub: share slab_err and object_err functions |
| |
On 10/27/2014 08:00 PM, Joe Perches wrote: > On Mon, 2014-10-27 at 19:46 +0300, Andrey Ryabinin wrote: >> Remove static and add function declarations to mm/slab.h so they >> could be used by kernel address sanitizer. > [] >> diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h > [] >> @@ -115,4 +115,8 @@ static inline void *virt_to_obj(struct kmem_cache *s, void *slab_page, void *x) > [] >> +void slab_err(struct kmem_cache *s, struct page *page, const char *fmt, ...); >> +void object_err(struct kmem_cache *s, struct page *page, >> + u8 *object, char *reason); > > Please add __printf(3, 4) to have the compiler catch > format and argument mismatches. > >
Will do, thanks.
| |