lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v1 03/10] regulator: act8865: Use of_is_system_power_controller helper function
    On Mon, Oct 27, 2014 at 04:26:48PM +0000, Romain Perier wrote:
    > Signed-off-by: Romain Perier <romain.perier@gmail.com>
    > ---
    > drivers/regulator/act8865-regulator.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
    > index 76301ed..435aba1 100644
    > --- a/drivers/regulator/act8865-regulator.c
    > +++ b/drivers/regulator/act8865-regulator.c
    > @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
    > return ret;
    > }
    >
    > - if (of_system_has_poweroff_source(dev->of_node)) {
    > + if (of_is_system_power_controller(dev->of_node)) {

    so building this driver is broken until this patch ? not very good
    either.

    Looks to me you should add of_is_system_power_controller without remove
    of_system_has_poweroff_source() until all users of that have been
    converted over.

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-10-27 18:21    [W:4.058 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site