lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] mmc/host/sdhci-of-arasan.c: Skip EPROBE_DEFER error messages
From
On 23 October 2014 13:47, Michal Simek <michal.simek@xilinx.com> wrote:
> Hi Chris,
>
> On 10/23/2014 01:31 PM, Mike Looijmans wrote:
>> When the error code is -EPROBE_DEFER, this will already be reported
>> so don't emit an error message in that case.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>> drivers/mmc/host/sdhci-of-arasan.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index 7ac6718..d5812a0 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -161,7 +161,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>> host = sdhci_pltfm_init(pdev, &sdhci_arasan_pdata, 0);
>> if (IS_ERR(host)) {
>> ret = PTR_ERR(host);
>> - dev_err(&pdev->dev, "platform init failed (%d)\n", ret);
>> + if (ret != -EPROBE_DEFER)
>> + dev_err(&pdev->dev, "platform init failed (%d)\n", ret);
>> goto clk_disable_all;
>> }
>>
>> @@ -172,7 +173,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>>
>> ret = sdhci_add_host(host);
>> if (ret) {
>> - dev_err(&pdev->dev, "platform register failed (%d)\n", ret);
>> + if (ret != -EPROBE_DEFER)
>> + dev_err(&pdev->dev, "platform register failed (%d)\n", ret);
>> goto err_pltfm_free;
>> }
>
>
> I checked other drivers and they are not reporting these bugs. I have briefly looked
> at sdhci_add_host and sdhci_platfm_init and they are pretty good error description
> + core itself should report if driver probe failed.
> That's why I think that it is just reasonable to remove these both dev_err completely.
>
> What do you think?

I agree, this seems reasonable!

Kind regards
Uffe


\
 
 \ /
  Last update: 2014-10-27 17:01    [W:0.101 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site