lkml.org 
[lkml]   [2014]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 005/127] Btrfs: dont do async reclaim during log replay
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Josef Bacik <jbacik@fb.com>

    commit f6acfd50110b335c7af636cf1fc8e55319cae5fc upstream.

    Trying to reproduce a log enospc bug I hit a panic in the async reclaim code
    during log replay. This is because we use fs_info->fs_root as our root for
    shrinking and such. Technically we can use whatever root we want, but let's
    just not allow async reclaim while we're doing log replay. Thanks,

    Signed-off-by: Josef Bacik <jbacik@fb.com>
    Signed-off-by: Chris Mason <clm@fb.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/extent-tree.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    --- a/fs/btrfs/extent-tree.c
    +++ b/fs/btrfs/extent-tree.c
    @@ -4508,7 +4508,13 @@ again:
    space_info->flush = 1;
    } else if (!ret && space_info->flags & BTRFS_BLOCK_GROUP_METADATA) {
    used += orig_bytes;
    - if (need_do_async_reclaim(space_info, root->fs_info, used) &&
    + /*
    + * We will do the space reservation dance during log replay,
    + * which means we won't have fs_info->fs_root set, so don't do
    + * the async reclaim as we will panic.
    + */
    + if (!root->fs_info->log_root_recovering &&
    + need_do_async_reclaim(space_info, root->fs_info, used) &&
    !work_busy(&root->fs_info->async_reclaim_work))
    queue_work(system_unbound_wq,
    &root->fs_info->async_reclaim_work);



    \
     
     \ /
      Last update: 2014-10-28 05:01    [W:2.300 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site