Messages in this thread | | | Date | Sat, 25 Oct 2014 12:44:48 +0200 | From | Sebastian Hesselbarth <> | Subject | Re: [PATCH 0/4] pinctrl: add helpers for group based drivers |
| |
On 20.10.2014 10:04, Antoine Tenart wrote: > Linus, Sebastian, > > As discussed earlier this year[1], this series introduce helpers for group based > pinctrl drivers: > - of_pinctrl_utils_read_function(): reads the function name of a > specified node, and gets the number of groups it should be > applied to. > - of_pinctrl_for_each_function_group(): navigates through the groups of > a specified node, reading at each iteration the name of the current > group. > > A generic function to parse nodes for group based drivers is also added, and > then used in the Berlin pinctrl driver: > - pinconf_generic_function_groups_dt_node_to_map() > > [1] https://lkml.org/lkml/2014/5/17/38
Antoine,
thanks for looking into this!
From Berlin POV,
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Antoine Tenart (4): > Documentation: bindings: pinctrl: document the generic groups property > pinctrl: add helpers for group based drivers > pinctrl: add a generic way to map node to map for group based drivers > pinctrl: berlin: use the generic node to map function > > .../bindings/pinctrl/pinctrl-bindings.txt | 1 + > drivers/pinctrl/berlin/Kconfig | 1 + > drivers/pinctrl/berlin/berlin.c | 53 +--------------------- > drivers/pinctrl/pinconf-generic.c | 36 +++++++++++++++ > drivers/pinctrl/pinctrl-utils.c | 26 +++++++++++ > drivers/pinctrl/pinctrl-utils.h | 9 ++++ > include/linux/pinctrl/pinconf-generic.h | 3 ++ > 7 files changed, 78 insertions(+), 51 deletions(-) >
| |