lkml.org 
[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/12] rtc: omap: add support for pmic_power_en
    On Wed, Oct 22, 2014 at 12:18:49PM +0200, Johan Hovold wrote:
    > On Fri, Oct 10, 2014 at 01:07:27PM -0500, Felipe Balbi wrote:
    > > On Thu, Oct 09, 2014 at 09:06:31PM +0200, Johan Hovold wrote:
    >
    > > > - /* clear pending irqs, and set 1/second periodic,
    > > > - * which we'll use instead of update irqs
    > > > + /*
    > > > + * disable interrupts
    > > > + *
    > > > + * NOTE: ALARM2 is not cleared on AM3352 if rtc_write (writeb) is used
    > > > */
    > > > - rtc_write(0, OMAP_RTC_INTERRUPTS_REG);
    > > > + rtc_writel(0, OMAP_RTC_INTERRUPTS_REG);
    > >
    > > bug fix, should be part of a separate patch and Cc stable :-)
    >
    > I made this a separate fix in v2 but did not mark it for stable for now
    > as no one has been bitten by it (ALARM2 is never enabled by the current
    > driver).

    makes sense.

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-10-23 21:21    [W:3.067 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site