lkml.org 
[lkml]   [2014]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/14] net: dsa/mv88e6352: Implement EEPROM access functions
    On Wed, Oct 22, 2014 at 09:03:18PM -0700, Guenter Roeck wrote:
    > MV88E6352 supports read and write access to its configuration eeprom.

    Hi Guenter

    I don't have the datasheet for the MV88E6352. Is the EEPROM built in,
    or external on an i2c bus?

    > +static int mv88e6352_get_eeprom_len(struct dsa_switch *ds)
    > +{
    > + return 0x200;
    > +}

    How do you handle the case of it being external and not populated.
    Would it not be better to try to detect it here, and return 0 if it
    does not exist?

    Andrew


    \
     
     \ /
      Last update: 2014-10-23 16:21    [W:4.021 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site