Messages in this thread | | | From | Prabhakar Lad <> | Date | Wed, 22 Oct 2014 22:48:12 +0100 | Subject | Re: [PATCH 10/15] media: davinci: vpbe: add support for VIDIOC_CREATE_BUFS |
| |
Hi Hans,
On Wed, Oct 22, 2014 at 12:26 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote: > Hi Prabhakar, > > This patch series looks good, except for this one. > > If you add create_bufs support, then you should also update queue_setup. > > If the fmt argument to queue_setup is non-NULL, then check that the > fmt.pix.sizeimage field is >= the current format's sizeimage. If not, > return -EINVAL. > > This prevents userspace from creating additional buffers that are smaller > than > the minimum required size. > > I'm just skipping this patch and queuing all the others for 3.19. Just post > an > updated version for this one and I'll pick it up later. > I fixed it and posted the patch. To avoid conflicts I have rebased the patch on for-v3.19a branch of your tree.
Thanks, --Prabhakar Lad
| |