| Date | Wed, 22 Oct 2014 23:32:46 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2 23/47] power/reset: gpio-poweroff: Register with kernel poweroff handler |
| |
Hi,
On Mon, Oct 20, 2014 at 09:12:39PM -0700, Guenter Roeck wrote: > Register with kernel poweroff handler instead of setting pm_power_off > directly. Register with low priority to reflect that the original code > only sets pm_power_off if it was not already set. > > Other changes: > > Drop note that there can not be an additional instance of this driver. > The original reason no longer applies, it should be obvious that there > can only be one instance of the driver if static variables are used to > reflect its state, and support for multiple instances can now be added > easily if needed by avoiding static variables. > > Do not create an error message if another poweroff handler has already > been registered. This is perfectly normal and acceptable. > > Drop remove function since it is no longer needed. > > Cc: Sebastian Reichel <sre@kernel.org> > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > Cc: David Woodhouse <dwmw2@infradead.org> > Acked-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian [unhandled content-type:application/pgp-signature] |