lkml.org 
[lkml]   [2014]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 09/59] dmaengine: Remove the need to declare device_control
    Date
    Hi Maxime,

    Thank you for the patch.

    On Wednesday 22 October 2014 17:43:23 Maxime Ripard wrote:
    > In order to migrate the drivers without triggering a BUG_ON for the
    > converted drivers, which would cause bisectability issues, we need to
    > remove that check before removing the device_control function entirely.
    >
    > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

    Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > drivers/dma/dmaengine.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
    > index 9b2cd74b8f2e..98e9431f85ec 100644
    > --- a/drivers/dma/dmaengine.c
    > +++ b/drivers/dma/dmaengine.c
    > @@ -820,8 +820,6 @@ int dma_async_device_register(struct dma_device *device)
    > !device->device_prep_dma_sg);
    > BUG_ON(dma_has_cap(DMA_CYCLIC, device->cap_mask) &&
    > !device->device_prep_dma_cyclic);
    > - BUG_ON(dma_has_cap(DMA_SLAVE, device->cap_mask) &&
    > - !device->device_control);
    > BUG_ON(dma_has_cap(DMA_INTERLEAVE, device->cap_mask) &&
    > !device->device_prep_interleaved_dma);

    --
    Regards,

    Laurent Pinchart



    \
     
     \ /
      Last update: 2014-10-22 23:21    [W:4.316 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site