Messages in this thread | | | From | Rusty Russell <> | Subject | Re: Re: [RFC PATCH 5/5] module: Remove stop_machine from module unloading | Date | Wed, 22 Oct 2014 14:55:03 +1030 |
| |
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> writes: >>> +/* >>> + * MODULE_REF_BASE must be 1, since we use atomic_inc_not_zero() for >>> + * recovering refcnt (see try_release_module_ref() ). >>> + */ >>> +#define MODULE_REF_BASE 1 >> >> True, but we could use atomic_add_unless() instead, and make this >> completely generic, right? > > Would you mean just replacing atomic_inc_not_zero() with atomic_add_unless()?
Yes.
Cheers, Rusty.
| |