Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v5 10/12] gpio: Support for unified device properties interface | Date | Mon, 20 Oct 2014 16:22:15 +0200 |
| |
On Monday 20 October 2014 01:58:57 Rafael J. Wysocki wrote: > > Actually, since the two last patches in the series, which currently are > the only users of these new functions, both pass "gpios" as the property > name and 0 as the index, I can simplify the functions so that (a) > fwnode_get_gpiod() takes fwnode and name and then simply passes 0 as the > index to either of_get_named_gpiod_flags() or acpi_get_gpiod_by_index() > and (b) devm_get_named_gpiod_from_child() takes only dev and fwnode (child) > and passes "gpios" as the property name to fwnode_get_gpiod(). The name > of devm_get_named_gpiod_from_child() could then be changed to something > like devm_get_gpiod_from_child() even. > > If anyone in the future needs anything more general, they can simply > add more complexity to that code, but for now we can go for a simplified > interface just fine. >
That sounds good, yes.
Arnd
| |