lkml.org 
[lkml]   [2014]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] ARM: meson: add meson8 machine definition
On gio, ott 02, 2014 at 07:05:19 +0200, Beniamino Galvani wrote:
> On Thu, Oct 02, 2014 at 11:24:54AM +0200, Arnd Bergmann wrote:
> > On Wednesday 01 October 2014 23:29:41 Beniamino Galvani wrote:
> > >
> > > +static const char * const m8_common_board_compat[] = {
> > > + "amlogic,meson8",
> > > + NULL,
> > > +};
> > > +
> > > DT_MACHINE_START(AML8726_MX, "Amlogic Meson6 platform")
> > > .dt_compat = m6_common_board_compat,
> > > MACHINE_END
> > >
> > > +DT_MACHINE_START(MESON8, "Amlogic Meson8 platform")
> > > + .dt_compat = m8_common_board_compat,
> > > +MACHINE_END
> > >
> >
> > I'd just add the meson8 string to the m6_common_board_compat list and
> > rename it.
>
> From what I've seen so far the two families are very similar and share
> most of the IP cores, so a unique DT machine is a good idea.
>
> Does the MACH_MESON8 Kconfig symbol still make sense or can I drop it
> and rename MACH_MESON6 to MACH_MESON?

I would still leave two different MACH_ for meson6 and meson8 since the
two architectures aren't _so_ similar.

thanks,

--
Carlo Caione


\
 
 \ /
  Last update: 2014-10-02 21:01    [W:0.050 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site