lkml.org 
[lkml]   [2014]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 02/53] dmaengine: Make channel allocation callbacks optional
    Date
    Hi Maxime,

    Thank you for the patch.

    On Thursday 16 October 2014 12:17:01 Maxime Ripard wrote:
    > Nowadays, some drivers don't have anything in there channel allocation
    > callbacks anymore.
    >
    > Remove the BUG_ON if those callbacks aren't implemented, in order to allow
    > drivers to not implement them.
    >
    > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
    > ---
    > drivers/dma/dmaengine.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
    > index d5d30ed863ce..cfcb181b1184 100644
    > --- a/drivers/dma/dmaengine.c
    > +++ b/drivers/dma/dmaengine.c
    > @@ -817,8 +817,6 @@ int dma_async_device_register(struct dma_device *device)
    > BUG_ON(dma_has_cap(DMA_INTERLEAVE, device->cap_mask) &&
    > !device->device_prep_interleaved_dma);
    >
    > - BUG_ON(!device->device_alloc_chan_resources);
    > - BUG_ON(!device->device_free_chan_resources);
    > BUG_ON(!device->device_tx_status);
    > BUG_ON(!device->device_issue_pending);
    > BUG_ON(!device->dev);

    This will make dma_chan_get() or dma_chan_put() crash if the alloc or free
    functions are not implemented.

    --
    Regards,

    Laurent Pinchart



    \
     
     \ /
      Last update: 2014-10-16 13:01    [W:4.147 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site