lkml.org 
[lkml]   [2014]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe
    On Sat, Oct 11, 2014 at 07:50:07PM -0500, Felipe Balbi wrote:
    > Hi,
    >
    > On Sat, Oct 11, 2014 at 12:20:04PM +0200, Johan Hovold wrote:
    > > On Fri, Oct 10, 2014 at 01:02:56PM -0500, Felipe Balbi wrote:
    > > > On Fri, Oct 10, 2014 at 01:00:54PM -0500, Felipe Balbi wrote:
    > > > > On Thu, Oct 09, 2014 at 09:06:29PM +0200, Johan Hovold wrote:
    > > > > > Some legacy RTC IP revisions has a power-up reset flag in the status
    > > > > > register that later revisions lack.
    > > > > >
    > > > > > As this flag is always read back as set on later revisions (or is
    > > > > > overloaded with a different flag), make sure to only clear the flag and
    > > > > > print the info message on legacy platforms.
    > > > > >
    > > > > > Signed-off-by: Johan Hovold <johan@kernel.org>
    > > > >
    > > > > Reviewed-by: Felipe Balbi <balbi@ti.com>
    > > >
    > > > oh, btw. This should be done for DT probes too.
    > >
    > > What do you mean? This is for DT probes (of "ti,da830-rtc" and
    > > "ti,am3352-rtc"). DT probing of legacy RTC IPs is currently not
    > > supported.
    > >
    > > Are you suggesting I should add a new compatible string for that?
    >
    > it seemed to me that you're only passing the new flag through
    > platform_device_id table, not DT table. Did I miss something ?

    Ah, that's just the way the driver currently encodes the IP revision
    differences. The platform_device_id entries are references from
    of_device_id data. Should probably clean that up as well.

    Thanks again for the review. I'll post a new version when I'm back from
    Düsseldorf and ELC-E/Plumbers.

    Johan
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-10-12 21:21    [W:2.278 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site