lkml.org 
[lkml]   [2014]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 22/85] drivers: gpu: Mark functions as static in radeon_device.c
From
On Wed, Jan 8, 2014 at 7:07 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Wed, Jan 08, 2014 at 11:40:28AM -0500, Alex Deucher wrote:
>> On Mon, Jan 6, 2014 at 10:21 AM, Rashika Kheria
>> <rashika.kheria@gmail.com> wrote:
>> > Mark functions radeon_doorbell_init() and radeon_doorbell_fini() as
>> > static in drm/radeon/radeon_device.c because they are not used outside
>> > this file.
>> >
>> > This eliminates the following warning in drm/radeon/radeon_device.c:
>> > drivers/gpu/drm/radeon/radeon_device.c:252:5: warning: no previous prototype for ‘radeon_doorbell_init’ [-Wmissing-prototypes]
>> > drivers/gpu/drm/radeon/radeon_device.c:281:6: warning: no previous prototype for ‘radeon_doorbell_fini’ [-Wmissing-prototypes]
>> >
>> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>>
>> I've pulled in a subset of these patches:
>> http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-next-3.14-wip
>> I held off on some of the others as I'd rather fix up the headers
>> properly rather than just cramming everything in radeon.h or
>> radeon-asic.h for now.
>
> Can you elaborate on which patches are putting functions in the wrong
> header, and what header you'd prefer to see them in?

Sure. atombios.h defines the vbios interface so it shouldn't have any
driver functions defined in it. radeon_asic.h was only supposed to
include the function definitions for the asic specific callbacks
assigned in radeon_asic.c. For everything else, I'd rather move to
asic specific headers, e.g., rather than adding r600_*() functions to
radeon.h for example, I'd rather add an r600.h and include that where
r600_*() functions are used, etc.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-01-09 16:21    [W:0.146 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site