Messages in this thread | | | Date | Thu, 9 Jan 2014 17:07:29 +0530 | From | Roger Quadros <> | Subject | Re: [PATCH v4 2/3] ata: ahci_platform: Manage SATA PHY |
| |
On 01/09/2014 04:50 PM, Sergei Shtylyov wrote: > On 09-01-2014 14:56, Roger Quadros wrote: > >> From: Balaji T K <balajitk@ti.com> > >> Some platforms have a PHY hooked up to the >> SATA controller. The PHY needs to be initialized >> and powered up for SATA to work. We do that >> using the PHY framework. > >> [Roger Q] Cleaned up. > >> CC: Tejun Heo <tj@kernel.org> >> Signed-off-by: Balaji T K <balajitk@ti.com> >> Signed-off-by: Roger Quadros <rogerq@ti.com> > [...] > >> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c >> index d5ced13..b476642 100644 >> --- a/drivers/ata/ahci_platform.c >> +++ b/drivers/ata/ahci_platform.c >> @@ -142,6 +142,39 @@ static int ahci_probe(struct platform_device *pdev) >> } >> } >> >> + hpriv->phy = devm_phy_get(dev, "sata-phy"); >> + if (IS_ERR(hpriv->phy)) { >> + rc = PTR_ERR(hpriv->phy); >> + switch (rc) { >> + case -ENODEV: >> + case -ENOSYS: >> + /* continue normally */ >> + hpriv->phy = NULL; >> + break; >> + >> + case -EPROBE_DEFER: >> + goto disable_unprepare_clk; >> + break; > > Well, well, *break* after *goto*? :-) > I know it is pointless functionally, but it is just my preference aesthetically.
Is it much of an issue if left as is?
cheers, -roger
| |