Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node. | Date | Wed, 08 Jan 2014 11:08:33 +0100 |
| |
On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote: > > + > > +Example: > > + > > + reboot@0 { > > + compatible = "apm,xgene-reboot"; > > + reg = <0x0 0x17000014 0x0 0x4>; > > + }; > > Given this seems to be a 64-bit address, the unit address should > preferably be 0,17000014 rather than just 0.
I also wonder about the size and location of the register. Are you sure the device is just a single 4-byte register at offset 0x14, rather than a complex device that happens to contain the reset register?
Arnd
| |