Messages in this thread | | | Date | Mon, 06 Jan 2014 21:22:30 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: delete non-required instances of include <linux/init.h> |
| |
On 01/06/2014 04:20 PM, Paul Gortmaker wrote: > None of these files are actually using any __init type directives > and hence don't need to include <linux/init.h>. Most are just a > left over from __devinit and __cpuinit removal, or simply due to > code getting copied from one driver to the next. > > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > > [build tested allyes/modconfig on x86/build from today's tip tree] >
Did you remember to test both 32 and 64 bits? I'm assuming not, since head_32.S no longer builds:
/home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S: Assembler messages: /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:86: Error: no such instruction: `__head' /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:476: Error: no such instruction: `__init' /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:635: Error: no such instruction: `__initdata' /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:640: Error: no such instruction: `__refdata' /home/hpa/kernel/tip.x86-cleanups/arch/x86/kernel/head_32.S:698: Error: no such instruction: `__initrodata' make[4]: *** [arch/x86/kernel/head_32.o] Error 1
-hpa
| |