lkml.org 
[lkml]   [2014]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6][RESEND] platform: x86: New BayTrail IOSF-SB MBI driver
On 01/07/14 10:03, David E. Box wrote:
> From: "David E. Box" <david.e.box@linux.intel.com>
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index b51a746..6e199a5 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -819,4 +819,14 @@ config PVPANIC
> a paravirtualized device provided by QEMU; it lets a virtual machine
> (guest) communicate panic events to the host.
>
> +config INTEL_BAYTRAIL_MBI
> + tristate

Is this kconfig option displayed when you run menuconfig/nconfig/xconfig/gconfig etc.?
Doesn't it need a prompt string?
How did you enable it and test it?

> + depends on PCI
> + ---help---
> + Needed on Baytrail platforms for access to the IOSF Sideband Mailbox
> + Interface. This is a requirement for systems that need to configure
> + the PUNIT for power management features such as RAPL. Register
> + addresses and r/w opcodes are defined in

Think of users reading this. At least change "r/w" to read/write.
What is IOSF? does it matter here?
PUNIT? RAPL?

> + drivers/platform/x86/intel_baytrail.c.
> +
> endif # X86_PLATFORM_DEVICES


--
~Randy


\
 
 \ /
  Last update: 2014-01-07 19:41    [W:0.078 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site