Messages in this thread | | | Subject | Re: [PATCH] pwm: core: Use devm_kzalloc instead of kzalloc | From | Joe Perches <> | Date | Mon, 06 Jan 2014 23:14:30 -0800 |
| |
On Tue, 2014-01-07 at 14:05 +0800, Xiubo Li wrote: > Use devm_kzalloc instead of kzalloc to free automatically and make > the cleanup paths simpler and the code slightly shorter. [] > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c [] > @@ -245,7 +244,9 @@ int pwmchip_add(struct pwm_chip *chip) > if (ret < 0) > goto out; > > - chip->pwms = kzalloc(chip->npwm * sizeof(*pwm), GFP_KERNEL); > + chip->pwms = devm_kzalloc(chip->dev, > + chip->npwm * sizeof(*pwm), > + GFP_KERNEL);
There is a devm_kcalloc and this should likely use it.
| |