Messages in this thread | | | From | Shaohui Xie <> | Subject | RE: [PATCH 5/6] [v4] phylib: Support attaching to generic 10g driver | Date | Tue, 7 Jan 2014 07:04:35 +0000 |
| |
> -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, January 07, 2014 1:56 PM > To: shh.xie@gmail.com > Cc: jg1.han@samsung.com; mugunthanvnm@ti.com; f.fainelli@gmail.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Xie Shaohui-B21989; > afleming@gmail.com > Subject: Re: [PATCH 5/6] [v4] phylib: Support attaching to generic 10g > driver > > From: <shh.xie@gmail.com> > Date: Tue, 7 Jan 2014 10:14:25 +0800 > > > -static int phy_attach_direct(struct net_device *dev, struct > > phy_device *phydev, > > +int phy_attach_direct(struct net_device *dev, struct phy_device > > +*phydev, > > u32 flags, phy_interface_t interface) > > Since you are changing where the open parenthesis is, you must reindent > the arguments on the second line so that they start exactly at the first > column after that openning parenthesis. > [S.H] OK. Thank you! Will fix it in next version.
Best Regards, Shaohui Xie
| |