lkml.org 
[lkml]   [2014]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] drm/i915: check LVDS for EDID on GPU switches
On Tue, Jan 07, 2014 at 04:42:12PM +0530, Ramkumar Ramachandra wrote:
> Chris Wilson wrote:
> > On Tue, Jan 07, 2014 at 03:28:43PM +0530, Ramkumar Ramachandra wrote:
> >> If the LVDS panel wasn't connected at boot then we won't have an EDID
> >> for it. To fix this, call intel_lvds_get_edid() from the vga_switcheroo
> >> reprobe callback.
> >
> > I would rather have an iterator over all our connectors (or perhaps
> > encoders would be the right semantic, except we have
> > connectors==encoders) and a reprobe callback.
>
> I don't follow; iterate over which connectors? There's one
> lvds_connector for which we get EDID.

Rather than special casing lvds (especially when there are other panel
connectors that can also be muxed), extend the connector interface to
support a reprobe and walk over all connectors associated with i915
after a switcheroo event.

> > Saves exporting private
> > functions and prevent me asking silly questions like what about eDP?
>
> Avoid exporting intel_lvds_get_edid()? Why?

Because it's a special case and misses others.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre


\
 
 \ /
  Last update: 2014-01-07 13:41    [W:0.043 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site