lkml.org 
[lkml]   [2014]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 011/144] staging: comedi: drivers: fix return value of comedi_load_firmware()
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: H Hartley Sweeten <hsweeten@visionengravers.com>

    commit c6236c0ce39c809c336ca929f68cf8ad02cf94e0 upstream.

    Some of the callback functions that upload the firmware in the comedi
    drivers return a positive value indicating the number of bytes sent
    to the device. Detect this condition and just return '0' to indicate
    a successful upload.

    Reported-by: Bernd Porr <mail@berndporr.me.uk>
    Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
    Acked-by: Ian Abbott <abbotti@mev.co.uk>
    Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/comedi/drivers.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/comedi/drivers.c
    +++ b/drivers/staging/comedi/drivers.c
    @@ -417,7 +417,7 @@ int comedi_load_firmware(struct comedi_d
    release_firmware(fw);
    }

    - return ret;
    + return ret < 0 ? ret : 0;
    }
    EXPORT_SYMBOL_GPL(comedi_load_firmware);




    \
     
     \ /
      Last update: 2014-01-07 03:41    [W:4.062 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site