Messages in this thread | | | Date | Mon, 6 Jan 2014 15:05:39 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 3.4 22/43] tg3: Expand 4g_overflow_test workaround to skb fragments of any size. |
| |
On Mon, Jan 06, 2014 at 02:58:55PM -0800, Eric Dumazet wrote: > On Mon, 2014-01-06 at 14:39 -0800, Greg Kroah-Hartman wrote: > > 3.4-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Nithin Sujir <nsujir@broadcom.com> > > > > commit 375679104ab3ccfd18dcbd7ba503734fb9a2c63a upstream. > > > > The current driver assumes that an skb fragment can only be upto jumbo > > size. Presumably this was a fast-path optimization. This assumption is > > no longer true as fragments can be upto 32k. > > > > v2: Remove unnecessary parantheses per Eric Dumazet. > > > > Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com> > > Signed-off-by: Michael Chan <mchan@broadcom.com> > > Signed-off-by: David S. Miller <davem@davemloft.net> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > --- > > drivers/net/ethernet/broadcom/tg3.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/net/ethernet/broadcom/tg3.c > > +++ b/drivers/net/ethernet/broadcom/tg3.c > > @@ -6619,7 +6619,7 @@ static inline int tg3_4g_overflow_test(d > > { > > u32 base = (u32) mapping & 0xffffffff; > > > > - return (base > 0xffffdcc0) && (base + len + 8 < base); > > + return base + len + 8 < base; > > } > > > > Minor comment : > > 32KB frags were added later, in 3.7. > > This patch makes no harm, so no worries.
Ah, thanks, I'll go drop it anyway.
greg k-h
| |