Messages in this thread | | | Date | Mon, 06 Jan 2014 13:07:26 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel |
| |
On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > Export APB DMA readl and writel. These are needed because we can't access > the fuses directly on Tegra20 without potentially causing a system hang.
This does a lot more than just export the functions; it also changes the prototypes. I'm not sure why the prototype change was required/useful. This needs to be mentioned in the commit description/subject, and the reasoning explained too.
> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h
> +#if defined(CONFIG_TEGRA20_APB_DMA) > +void tegra_apb_io_init(void);
This seems to be an internal function; why is this one publicly prototyped and/or stubbed?
| |