lkml.org 
[lkml]   [2014]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [dm-devel] [PATCH] kobject: provide kobject_put_wait to fix module unload race
On 01/04/14 19:06, Mikulas Patocka wrote:
> - if (t && !t->release)
> - pr_debug("kobject: '%s' (%p): does not have a release() "
> - "function, it is broken and must be fixed.\n",
> - kobject_name(kobj), kobj);
> -

Has it been considered to issue a warning if no release function has
been defined and free_completion == NULL instead of removing the above
debug message entirely ? I think even with this patch applied it is
still wrong to invoke kobject_put() on an object without defining a
release function.

Thanks,

Bart.



\
 
 \ /
  Last update: 2014-01-05 18:21    [W:0.136 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site