Messages in this thread | | | Date | Sun, 05 Jan 2014 17:43:56 +0100 | From | Bart Van Assche <> | Subject | Re: [dm-devel] [PATCH] kobject: provide kobject_put_wait to fix module unload race |
| |
On 01/04/14 19:06, Mikulas Patocka wrote: > - if (t && !t->release) > - pr_debug("kobject: '%s' (%p): does not have a release() " > - "function, it is broken and must be fixed.\n", > - kobject_name(kobj), kobj); > -
Has it been considered to issue a warning if no release function has been defined and free_completion == NULL instead of removing the above debug message entirely ? I think even with this patch applied it is still wrong to invoke kobject_put() on an object without defining a release function.
Thanks,
Bart.
| |