lkml.org 
[lkml]   [2014]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 1/2] mm: add kstrimdup function
Date
Quoting Joe Perches (2014-01-29 17:24:28)
> Why not minimize the malloc length too?
>
> maybe something like:
>
> char *kstrimdup(const char *s, gfp_t gfp)
> {
> char *buf;
> const char *begin = skip_spaces(s);
> size_t len = strlen(begin);
>
> while (len && isspace(begin[len - 1]))
> len--;
>
> buf = kmalloc_track_caller(len + 1, gfp);
> if (!buf)
> return NULL;
>
> memcpy(buf, begin, len);
> buf[len] = 0;
>
> return buf;
> }

I figured it would be mostly for small trimming, but it seems like
it could be and advantage and used more generally this way.

I have a couple of small changes to return NULL in empty string/all ws
cases and fix a buffer underrun.

How does this look?

Thanks,

Sebastian


char *kstrimdup(const char *s, gfp_t gfp)
{
char *buf;
const char *begin = skip_spaces(s);
size_t len = strlen(begin);

if (len == 0)
return NULL;

while (len > 1 && isspace(begin[len - 1]))
len--;

buf = kmalloc_track_caller(len + 1, gfp);
if (!buf)
return NULL;

memcpy(buf, begin, len);
buf[len] = '\0';

return buf;
}





\
 
 \ /
  Last update: 2014-01-30 05:21    [W:0.048 / U:1.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site