Messages in this thread | | | Date | Wed, 29 Jan 2014 17:25:40 +0530 | Subject | Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup" | From | Manish Badarkhe <> |
| |
Hi Mark,
On Wed, Jan 29, 2014 at 5:10 PM, Mark Brown <broonie@kernel.org> wrote: > On Wed, Jan 29, 2014 at 04:38:20PM +0530, Manish Badarkhe wrote: >> On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches <joe@perches.com> wrote: > >> >> + buf = devm_kzalloc(dev, size, gfp); > >> > If this is really necessary, please use devm_kmalloc > >> devm_kzalloc is always better giving zeroed memory locations. >> Is there any reason not to go for it? > > If the allocated memory is going to be immediately overwritten with the > string then it shouldn't make any difference if it was zeroed when > allocated.
Thank you for clarification. I will go ahead to make it devm_kmalloc and post a new version of patch.
Regards Manish Badarkhe
| |