lkml.org 
[lkml]   [2014]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] mm: sl[uo]b: fix misleading comments
On Tue, 28 Jan 2014, Dave Hansen wrote:

> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> On x86, SLUB creates and handles <=8192-byte allocations internally.
> It passes larger ones up to the allocator. Saying "up to order 2" is,
> at best, ambiguous. Is that order-1? Or (order-2 bytes)? Make
> it more clear.
>
> SLOB commits a similar sin. It *handles* page-size requests, but the
> comment says that it passes up "all page size and larger requests".
>
> SLOB also swaps around the order of the very-similarly-named
> KMALLOC_SHIFT_HIGH and KMALLOC_SHIFT_MAX #defines. Make it
> consistent with the order of the other two allocators.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

Acked-by: David Rientjes <rientjes@google.com>


\
 
 \ /
  Last update: 2014-01-29 06:41    [W:0.049 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site