Messages in this thread | | | Date | Wed, 22 Jan 2014 14:33:14 -0800 | From | David Cohen <> | Subject | Re: [PATCH] x86: don't add new __cpuinit users to Merrifield platform code |
| |
On Wed, Jan 22, 2014 at 02:23:33PM -0800, H. Peter Anvin wrote: > On 01/22/2014 10:09 AM, David Cohen wrote: > > On Wed, Jan 22, 2014 at 10:08:03AM -0800, David Cohen wrote: > >> On Wed, Jan 22, 2014 at 12:35:25PM -0500, Paul Gortmaker wrote: > >>> Commit bc20aa48bbb3068224a1c91f8332971fdb689fad ("x86, intel-mid: > >>> Add Merrifield platform support") added new instances of __cpuinit > >>> usage. We removed this a couple versions ago; we now want to remove > >>> the compat no-op stubs. Introducing new users is not what we want to > >>> see at this point in time, as it will break once the stubs are gone. > >>> > >>> This also fixes an out of sync __init vs. __cpuinit -- as the former > >>> is real, and the latter is a no-op; hence it would have been a section > >>> mismatch. > >>> > >>> Cc: David Cohen <david.a.cohen@linux.intel.com> > >>> Cc: Fei Yang <fei.yang@intel.com> > >>> Cc: H. Peter Anvin <hpa@linux.intel.com> > >>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > >> > >> Thanks for the patch. > >> > >> Acked-by: David Cohen <david.a.cohen@linux.intel.com> > > > > Grr... wrong acked version :) > > I'm getting back this ack. > > ?! I don't see any other version?
I misread mrfl and mfld. There is another version for mfld only :)
My ack is indeed valid here. Sorry for my misunderstanding.
Br, David
> > -hpa >
| |