Messages in this thread | | | From | "Hyeoncheol Lee" <> | Subject | RE: [PATCH 15/17] tracing/uprobes: Add support for full argument access methods | Date | Fri, 3 Jan 2014 10:17:23 +0900 |
| |
Patches look good to me.
Signed-off-by: Hyeoncheol Lee <cheol.lee@lge.com>
-----Original Message----- From: Steven Rostedt [mailto:rostedt@goodmis.org] Sent: Friday, January 03, 2014 6:02 AM To: Steven Rostedt Cc: Namhyung Kim; Oleg Nesterov; Masami Hiramatsu; Srikar Dronamraju; Hyeoncheol Lee; zhangwei(Jovi); Arnaldo Carvalho de Melo; Hemant Kumar; LKML; Namhyung Kim Subject: Re: [PATCH 15/17] tracing/uprobes: Add support for full argument access methods
On Thu, 2 Jan 2014 15:58:27 -0500 Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 16 Dec 2013 13:32:14 +0900 > Namhyung Kim <namhyung@kernel.org> wrote: > > > From: Namhyung Kim <namhyung.kim@lge.com> > > > > Enable to fetch other types of argument for the uprobes. IOW, we > > can access stack, memory, deref, bitfield and retval from uprobes now. > > > > The format for the argument types are same as kprobes (but @SYMBOL > > type is not supported for uprobes), i.e: > > > > @ADDR : Fetch memory at ADDR > > $stackN : Fetch Nth entry of stack (N >= 0) > > $stack : Fetch stack address > > $retval : Fetch return value > > +|-offs(FETCHARG) : Fetch memory at FETCHARG +|- offs address > > > > Note that the retval only can be used with uretprobes. > > > > Original-patch-by: Hyeoncheol Lee <cheol.lee@lge.com> > > Where was the original patch posted? And can we get Hyeoncheol's SOB > for this? >
Was this the other part of patch 11? Still should have Hyeoncheol's signed-off-by. If you already had it on the original (before the split) then we can add it here too, as he already signed off on the code that this was based on.
-- Steve
| |