Messages in this thread | | | Date | Wed, 15 Jan 2014 09:02:11 +0100 | Subject | Re: [PATCH 1/3] mfd: MAX6650/6651 support | From | Linus Walleij <> |
| |
On Fri, Jan 10, 2014 at 10:56 AM, Lee Jones <lee.jones@linaro.org> wrote: > On Thu, 09 Jan 2014, Laszlo Papp wrote: > >> >> +int max6651_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest) >> >> +{ >> > >> > Probably best to use Regmap instead. >> > >> > regmap_i2c_read() >> >> >> +int max6651_write_reg(struct i2c_client *i2c, u8 reg, u8 value) >> >> +{ >> >> + struct max6651_dev *max6651 = i2c_get_clientdata(i2c); >> >> + int ret; >> > >> > Same here. >> > >> > regmap_i2c_write() >> >> Hmm, but what Linus linked is using regmap_read/write(...) instead of >> regmap_i2c_read/write(...). >> >> I thought I would need to be using the former. Perhaps, I >> misunderstand something? >> >> I do not even find the aforementioend functions used by drivers based >> on this LXR result: >> http://lxr.free-electrons.com/ident?i=regmap_i2c_write > > Linus is in a better position to know, use his suggestion.
Just use regmap_read/write to abstract things and hide the underlying marshalling in regmap.
regmap_i2c_write is some regmap-internal thing.
Yours, Linus Walleij
| |