lkml.org 
[lkml]   [2014]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v5 2/9] mfd: omap-usb-host: Get clocks based on hardware revision
    Date
    On Friday 10 January 2014, Lee Jones wrote:
    > >
    > > - need_logic_fck = false;
    > > + /* Set all clocks as invalid to begin with */
    > > + omap->ehci_logic_fck = omap->init_60m_fclk = ERR_PTR(-EINVAL);
    > > + omap->utmi_p1_gfclk = omap->utmi_p2_gfclk = ERR_PTR(-EINVAL);
    > > + omap->xclk60mhsp1_ck = omap->xclk60mhsp2_ck = ERR_PTR(-EINVAL);
    >
    > I don't think this is the correct error code.
    >
    > -EINVAL means 'invalid parameter'.
    >
    > You probably want -ENODEV or -ENOSYS ('function not implemented'
    > probably isn't ideal either tbh, but you get the idea). Perhaps you
    > can set them as NULL and check for IS_ERR_OR_NULL() instead?

    I think ENODEV is ok here, I'd much prefer this over IS_ERR_OR_NULL().

    Arnd


    \
     
     \ /
      Last update: 2014-01-10 16:01    [W:2.229 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site