Messages in this thread | | | Date | Tue, 10 Sep 2013 10:50:49 +0800 | Subject | Re: Question regarding list_for_each_entry_safe usage in move_one_task | From | Lei Wen <> |
| |
On Mon, Sep 9, 2013 at 7:15 PM, Peter Zijlstra <peterz@infradead.org> wrote: > On Mon, Sep 02, 2013 at 02:26:45PM +0800, Lei Wen wrote: >> Hi Peter, >> >> I find one list API usage may not be correct in current fair.c code. >> In move_one_task function, it may iterate through whole cfs_tasks >> list to get one task to move. >> >> But in dequeue_task(), it would delete one task node from list >> without the lock protection. So that we could see from >> list_for_each_entry_safe API definitoin: > > Both sites hold the required rq->lock.
I see, sorry for the noise...
Thanks, Lei
| |