lkml.org 
[lkml]   [2013]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/11] x86, memblock: Allocate memory near kernel image before SRAT parsed.
Hi tj,

On 09/05/2013 03:22 AM, Tejun Heo wrote:
......
> I'm expectedly happier with this approach but some overall review
> points.
>
> * I think patch splitting went a bit too far. e.g. it doesn't make
> much sense or helps anything to split "introduction of a param" from
> "the param doing something".
>
> * I think it's a lot more complex than necessary. Just implement a
> single function - memblock_alloc_bottom_up(@start) where specifying
> MEMBLOCK_ALLOC_ANYWHERE restores top down behavior and do
> memblock_alloc_bottom_up(end_of_kernel) early during boot. If the
> bottom up mode is set, just try allocating bottom up from the
> specified address and if that fails do normal top down allocation.
> No need to meddle with the callers. The only change necessary
> (well, aside from the reordering) outside memblock is adding two
> calls to the above function.
>
> * I don't think "order" is the right word here. "direction" probably
> fits a lot better.
>

Thanks for the advices. I'll try to simply the code and send a new
patch-set soon.

Thanks.





\
 
 \ /
  Last update: 2013-09-05 11:21    [W:0.218 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site