Messages in this thread | | | From | Bjorn Helgaas <> | Date | Tue, 3 Sep 2013 12:09:31 -0600 | Subject | Re: [Ksummit-2013-discuss] [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle |
| |
On Mon, Sep 2, 2013 at 6:39 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> Thanks! Yes I'm now running checkpatch these days because some people > suggested to me that some of the checkpatch warnings do help catch > real bugs. > > However I do try to avoid upsetting people with maybe-subjective > warnings. A checkpatch report will only be sent when a small fraction > of error types are detected. Comments are very welcome on how to > improve this list:
How hard would it be to make this configurable per-git tree? I think the robot is quite useful and I don't push branches very often, so I'd probably be OK with just getting all the checkpatch warnings along with the build warnings and filtering the noise myself. But I know other people have different styles and opinions.
> MEMSET > IN_ATOMIC > UAPI_INCLUDE > MALFORMED_INCLUDE > SIZEOF_ADDRESS > KREALLOC_ARG_REUSE > EXECUTE_PERMISSIONS > ERROR:BAD_SIGN_OFF > LO_MACRO > HI_MACRO > CSYNC > SSYNC > HOTPLUG_SECTION > INDENTED_LABEL > INLINE_LOCATION > STORAGE_CLASS > USLEEP_RANGE > UNNECESSARY_CASTS > ALLOC_SIZEOF_STRUCT > KREALLOC_ARG_REUSE > USE_FUNC > LOCKDEP > EXPORTED_WORLD_WRITABLE > WHITESPACE_AFTER_LINE_CONTINUATION > MISSING_VMLINUX_SYMBOL > NEEDLESS_IF > PRINTF_L > > Once the decision is made to send a checkpatch error/warning, the > report email will use the triggering error (the one that matters) as > the email subject, with the complete output of checkpatch.pl included > in email body. > > Thanks, > Fengguang > _______________________________________________ > Ksummit-2013-discuss mailing list > Ksummit-2013-discuss@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-2013-discuss
| |