Messages in this thread | | | Date | Tue, 3 Sep 2013 09:22:24 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH 03/18 v2] ftrace: Set ftrace internal function tracing RCU safe |
| |
On Sat, 31 Aug 2013 12:44:31 -0700 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> On Sat, Aug 31, 2013 at 01:11:20AM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > > > Since none of the internal ftrace function tracing uses RCU in > > their callbacks, it is OK to set the global_ops (the one that > > they all use) to RCU safe. > > > > Cc: Jiri Olsa <jolsa@redhat.com> > > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > > Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
You must have liked this patch so much... that you acked it twice ;-)
-- Steve
> > > --- > > kernel/trace/ftrace.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > index d61f431..a45deaa 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -1146,7 +1146,9 @@ static struct ftrace_ops global_ops = { > > .func = ftrace_stub, > > .notrace_hash = EMPTY_HASH, > > .filter_hash = EMPTY_HASH, > > - .flags = FTRACE_OPS_FL_RECURSION_SAFE | FTRACE_OPS_FL_INITIALIZED, > > + .flags = FTRACE_OPS_FL_RECURSION_SAFE | > > + FTRACE_OPS_FL_INITIALIZED | > > + FTRACE_OPS_FL_RCU_SAFE, > > INIT_REGEX_LOCK(global_ops) > > }; > > > > -- > > 1.7.10.4 > > > >
| |