Messages in this thread Patch in this message | | | From | "Geyslan G. Bem" <> | Subject | [PATCH] 9p: fix return value in case of error in v9fs_fid_xattr_set | Date | Sat, 28 Sep 2013 20:32:17 -0300 |
| |
In case of error in the p9_client_write, the function v9fs_fid_xattr_set should return its negative value, what was never being done.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> --- fs/9p/xattr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c index 3c28cdf..0788388 100644 --- a/fs/9p/xattr.c +++ b/fs/9p/xattr.c @@ -149,11 +149,10 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name, write_count = value_len; write_count = p9_client_write(fid, ((char *)value)+offset, NULL, offset, write_count); - if (write_count < 0) { - /* error in xattr write */ - retval = write_count; - break; - } + /* error in xattr write */ + if (write_count < 0) + return write_count; + offset += write_count; value_len -= write_count; } -- 1.8.4
| |