lkml.org 
[lkml]   [2013]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform_driver'
From
On Sat, Sep 28, 2013 at 8:14 PM,  <elad.wexler@gmail.com> wrote:
> From: Elad Wexler <elad.wexler@gmail.com>
>
> Driver doesn't do anything special in 'module_init'.
>
> 'module_platform_init' makes the code more readable.
>
> Signed-off-by: Elad Wexler <elad.wexler@gmail.com>

NAK.

By moving to module_platform_init() you make this module unloadable.
Currently it is unloadable for good reasons.
The cs5535-mfgpt chip is nasty because it has no reliable reset function.
Therefore by unloading and loading the module again bad things can happen.

--
Thanks,
//richard


\
 
 \ /
  Last update: 2013-09-28 21:21    [W:1.218 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site