Messages in this thread | | | Date | Sat, 28 Sep 2013 20:54:55 +0200 | Subject | Re: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform_driver' | From | richard -rw- weinberger <> |
| |
On Sat, Sep 28, 2013 at 8:14 PM, <elad.wexler@gmail.com> wrote: > From: Elad Wexler <elad.wexler@gmail.com> > > Driver doesn't do anything special in 'module_init'. > > 'module_platform_init' makes the code more readable. > > Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
NAK.
By moving to module_platform_init() you make this module unloadable. Currently it is unloadable for good reasons. The cs5535-mfgpt chip is nasty because it has no reliable reset function. Therefore by unloading and loading the module again bad things can happen.
-- Thanks, //richard
| |