Messages in this thread | | | Date | Fri, 27 Sep 2013 16:50:07 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] checkpatch: Make the memory barrier test noisier |
| |
On Fri, Sep 27, 2013 at 07:34:55AM -0700, Joe Perches wrote: > That would make it seem as if all barriers are SMP no?
I would think any memory barrier is ordering against someone else; if not smp then a device/hardware -- like for instance the hardware page table walker.
Barriers are fundamentally about order; and order only makes sense if there's more than 1 party to the game.
> Maybe just refer to Documentation/memory-barriers.txt > and/or say something like "please document appropriately"
Documentation/memory-barriers.txt is always good; appropriately doesn't seem to quantify anything much at all. Someone might think:
/* */ smp_mb();
appropriate...
| |