lkml.org 
[lkml]   [2013]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] checkpatch: Make the memory barrier test noisier
    From
    Date
    Peter Zijlstra prefers that comments be required near uses
    of memory barriers.

    Change the message level for memory barrier uses from a
    --strict test only to a normal WARN so it's always emitted.

    This might produce false positives around insertions of
    memory barriers when a comment is outside the patch context
    block.

    And checkpatch is still stupid, it only looks for existence
    of any comment, not at the comment content.

    Suggested-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    scripts/checkpatch.pl | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index c03e427..bd4103a 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -3816,8 +3816,8 @@ sub string_find_replace {
    # check for memory barriers without a comment.
    if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
    if (!ctx_has_comment($first_line, $linenr)) {
    - CHK("MEMORY_BARRIER",
    - "memory barrier without comment\n" . $herecurr);
    + WARN("MEMORY_BARRIER",
    + "memory barrier without comment\n" . $herecurr);
    }
    }
    # check of hardware specific defines




    \
     
     \ /
      Last update: 2013-09-27 16:21    [W:3.686 / U:1.812 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site