lkml.org 
[lkml]   [2013]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] sysfs: @name comes before @ns
On Wed, Sep 11, 2013 at 11:49:43PM -0400, Tejun Heo wrote:
> Hello, Eric.
>
> On Wed, Sep 11, 2013 at 08:39:27PM -0700, Eric W. Biederman wrote:
> > @ns is more significant so it should come first.
> >
> > Where do we have the backwards convention of putting @name first?
>
> Because @ns is optional and you end up with stupid stuff like
>
> sysfs_xxx_ns(@param, @ns, @name)
> sysfs_xxx(@param, @name)
>
> You put optional params after the mandatory ones. It may be difficult
> to accept for you but @ns is a *clearly* optional thing for sysfs.

Sorry Eric, but I agree with Tejun here, the optional part is @ns, not
name, so it should go at the end.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-09-27 01:01    [W:0.053 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site