Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH V2 05/18] regulator: fixed: use devm_regulator_register() | Date | Thu, 26 Sep 2013 15:25:59 +0900 |
| |
On Thursday, September 26, 2013 3:14 PM, Sachin Kamat wrote: > On 26 September 2013 07:35, Jingoo Han <jg1.han@samsung.com> wrote: > > Use devm_regulator_register() to make cleanup paths simpler. > > > struct fixed_voltage_data *drvdata = platform_get_drvdata(pdev); > > > > - regulator_unregister(drvdata->dev); > > kfree(drvdata->desc.supply_name); > > kfree(drvdata->desc.name); > > Sorry, couldn't go through all your patches yesterday. > This one looks a bit scary too as some of the driver data is already > freed before unregistering. >
I looked at regulator_unregister(). I am not sure that this is safe. So, I will remove this patch from next v3 patch series. Thank you for your comment. :-)
Best regards, Jingoo Han
| |