Messages in this thread | | | Date | Fri, 27 Sep 2013 00:51:36 +0800 | From | Zhang Yanfei <> | Subject | Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode |
| |
On 09/26/2013 11:37 PM, Zhang Yanfei wrote: > Hello tejun, > > Thanks for your quick comments first:) > > On 09/26/2013 10:45 PM, Tejun Heo wrote: >> Hello, >> >> On Wed, Sep 25, 2013 at 02:27:48AM +0800, Zhang Yanfei wrote: >>> +#ifdef CONFIG_MOVABLE_NODE >>> +static inline void memblock_set_bottom_up(bool enable) >>> +{ >>> + memblock.bottom_up = enable; >>> +} >>> + >>> +static inline bool memblock_bottom_up(void) >>> +{ >>> + return memblock.bottom_up; >>> +} >> >> Can you please explain what this is for here? > > OK, will do.
I write the function description here so you could give your comments still in this version.
/* * Set the allocation direction to bottom-up or top-down. */ static inline void memblock_set_bottom_up(bool enable) { memblock.bottom_up = enable; }
/* * Check if the allocation direction is bottom-up or not. * if this is true, that said, the boot option "movablenode" * has been specified, and memblock will allocate memory * just near the kernel image. */ static inline bool memblock_bottom_up(void) { return memblock.bottom_up; }
Thanks.
-- Thanks. Zhang Yanfei
| |